Make Makefile a little easier to use #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vrothberg @mtrmac @QiWang19 PTAL |
mtrmac
reviewed
Oct 8, 2020
By default we should build bin/skopeo locally and build docs locally. Show output when doing make docs. Add description in `make help` to explain default behaviour. Signed-off-by: Daniel J Walsh <[email protected]>
|
Closes: #755 |
QiWang19
reviewed
Oct 8, 2020
mtrmac
reviewed
Oct 8, 2020
Co-authored-by: Miloslav Trmač <[email protected]>
Co-authored-by: Tom Sweeney <[email protected]>
mtrmac
reviewed
Oct 9, 2020
|
@mtrmac nope. |
Just restarted it but I had to sign in. |
vrothberg
reviewed
Oct 9, 2020
|
LGTM |
1 similar comment
|
LGTM |
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default we should build bin/skopeo locally
and build docs locally.
Show output when doing make docs.
Add description in
make helpto explain defaultbehaviour.
Fixes: #580
Signed-off-by: Daniel J Walsh [email protected]